Talk:UnsafeWindow: Difference between revisions
From GreaseSpot Wiki
Jump to navigationJump to search
How to do I use GM_setValue safely? |
|||
Line 17: | Line 17: | ||
* Is it safe? | * Is it safe? | ||
* Is there a better way that does not involve unsafeWindow? | * Is there a better way that does not involve unsafeWindow? | ||
:You should be able to just define the method on <code>window</code>. So try just | |||
function updatePref(state) { | |||
… | |||
} |
Revision as of 08:13, 6 May 2007
We should add an example of an exploit. If not running code (would be nice) for security-by-obscurity reasons, then at least explain what could happen. --195.67.240.29 17:39, 13 April 2007 (EDT)
How to do I use GM_setValue safely?
I want to insert in the page an HTML element that can be used to update a preference.
My strategy for doing this is:
- add the element in the userScript, with an onclick property set to call updatePref(new_state);
- add a function to update the setting to unsafeWindow, here is the function:
unsafeWindow.updatePref = function(state) { var s; if (state) { s = true; } else { s = false; } GM_setValue('pref', s); };
Questions:
- Is it safe?
- Is there a better way that does not involve unsafeWindow?
- You should be able to just define the method on
window
. So try just
function updatePref(state) { … }